Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: upgrade tidb dependency to latest master #11605

Merged
merged 6 commits into from
Sep 20, 2024

Conversation

D3Hunter
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. area/dm Issues or PRs related to DM. area/engine Issues or PRs related to Dataflow Engine. labels Sep 19, 2024
@D3Hunter D3Hunter added the skip-issue-check Indicates that a PR no need to check linked issue. label Sep 19, 2024
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Sep 19, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 20, 2024
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

ti-chi-bot bot commented Sep 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, hongyunyan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 20, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-20 06:12:15.465135067 +0000 UTC m=+1200805.205558999: ☑️ agreed by hongyunyan.
  • 2024-09-20 06:13:34.465498402 +0000 UTC m=+1200884.205922342: ☑️ agreed by GMHDBJD.

@D3Hunter
Copy link
Contributor Author

/retest

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 83.58209% with 11 lines in your changes missing coverage. Please review.

Project coverage is 57.4645%. Comparing base (45c831a) to head (29bbc15).
Report is 1 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 61.2226% <75.0000%> (-0.0096%) ⬇️
dm 51.0253% <88.3720%> (-0.0081%) ⬇️
engine 63.3526% <ø> (-0.0424%) ⬇️
Flag Coverage Δ
unit 57.4645% <83.5820%> (-0.0127%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11605        +/-   ##
================================================
- Coverage   57.4771%   57.4645%   -0.0127%     
================================================
  Files           851        851                
  Lines        126539     126539                
================================================
- Hits          72731      72715        -16     
- Misses        48407      48420        +13     
- Partials       5401       5404         +3     

@D3Hunter
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 592a62f into pingcap:master Sep 20, 2024
28 checks passed
@D3Hunter D3Hunter deleted the upgrade-tidb branch September 20, 2024 15:07
wk989898 pushed a commit to wk989898/tiflow that referenced this pull request Sep 23, 2024
@wk989898
Copy link
Collaborator

/cherrypick feature/vector-data-type

@ti-chi-bot
Copy link
Member

@wk989898: new pull request created to branch feature/vector-data-type: #11618.

In response to this:

/cherrypick feature/vector-data-type

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Sep 23, 2024
wk989898 pushed a commit to wk989898/tiflow that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dm Issues or PRs related to DM. area/engine Issues or PRs related to Dataflow Engine. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants