Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mounter(ticdc): calculate raw bytes checksum by using handle #11720

Merged
merged 10 commits into from
Nov 7, 2024
Merged

mounter(ticdc): calculate raw bytes checksum by using handle #11720

merged 10 commits into from
Nov 7, 2024

Conversation

3AceShowHand
Copy link
Contributor

@3AceShowHand 3AceShowHand commented Nov 5, 2024 •
edited by CharlesCheung96
Loading

What problem does this PR solve?

Issue Number: close #11713

What is changed and how it works?

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

none

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 5, 2024
@3AceShowHand 3AceShowHand changed the title [DNM] mounter(ticdc): calculate raw bytes checksum by using handle mounter(ticdc): calculate raw bytes checksum by using handle Nov 7, 2024
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Nov 7, 2024
@3AceShowHand 3AceShowHand added needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. labels Nov 7, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 7, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 7, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 7, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-07 03:10:55.806242362 +0000 UTC m=+1096968.645397906: ☑️ agreed by CharlesCheung96.
  • 2024-11-07 03:17:00.837528196 +0000 UTC m=+1097333.676683741: ☑️ agreed by sdojjy.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, CharlesCheung96, sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CharlesCheung96,asddongmen,sdojjy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@3AceShowHand
Copy link
Contributor Author

/retest

3 similar comments
@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

1 similar comment
@3AceShowHand
Copy link
Contributor Author

/retest

@wk989898
Copy link
Collaborator

wk989898 commented Nov 7, 2024

/retest

1 similar comment
@wk989898
Copy link
Collaborator

wk989898 commented Nov 7, 2024

/retest

@yinsustart
Copy link

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

1 similar comment
@3AceShowHand
Copy link
Contributor Author

/retest

@codecov Codecov
Copy link

codecov bot commented Nov 7, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 30.00000% with 28 lines in your changes missing coverage. Please review.

Project coverage is 55.1534%. Comparing base (5c7d683) to head (64c4f3a).
Report is 3 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 59.6131% <30.0000%> (-0.0197%) ⬇️
dm 50.0673% <ø> (+0.0153%) ⬆️
engine 53.2449% <ø> (+0.0338%) ⬆️
Flag Coverage Δ
unit 55.1534% <30.0000%> (+0.0013%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11720        +/-   ##
================================================
+ Coverage   55.1520%   55.1534%   +0.0013%     
================================================
  Files          1001       1001                
  Lines        136499     136521        +22     
================================================
+ Hits          75282      75296        +14     
- Misses        55708      55714         +6     
- Partials       5509       5511         +2

@3AceShowHand
Copy link
Contributor Author

/retest

3 similar comments
@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 64decf6 into pingcap:master Nov 7, 2024
28 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #11730.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 7, 2024
Merged
@wk989898 wk989898 mentioned this pull request Nov 7, 2024
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.4: #11731.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Nov 7, 2024
@3AceShowHand @ti-chi-bot
This is an automated cherry-pick of pingcap#11720
3cfa687 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 7, 2024
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Nov 8, 2024
@ti-chi-bot
mounter(ticdc): calculate raw bytes checksum by using handle (#11720) (…
ad58c8b 
…#11731)

close #11713
ti-chi-bot bot pushed a commit that referenced this pull request Nov 8, 2024
@ti-chi-bot
mounter(ticdc): calculate raw bytes checksum by using handle (#11720) (…
d238ea7 
…#11730)

close #11713
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlesCheung96 CharlesCheung96 CharlesCheung96 approved these changes

@asddongmen asddongmen asddongmen approved these changes

@sdojjy sdojjy sdojjy approved these changes

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

checksum mismatch when restored backup with checksum v2 and table id changes
7 participants
@3AceShowHand @wk989898 @yinsustart @ti-chi-bot @sdojjy @asddongmen @CharlesCheung96