Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dm: fix MariaDB up down test #11750

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

GMHDBJD
Copy link
Contributor

@GMHDBJD GMHDBJD commented Nov 14, 2024

What problem does this PR solve?

Issue Number: close #4287

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 14, 2024
@ti-chi-bot ti-chi-bot bot added area/dm Issues or PRs related to DM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.1772%. Comparing base (68c22f3) to head (26184d0).
Report is 2 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 59.5918% <ø> (∅)
dm 50.0846% <ø> (∅)
engine 53.2392% <ø> (+0.0169%) ⬆️
Flag Coverage Δ
unit 55.1772% <ø> (+1.9549%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11750        +/-   ##
================================================
+ Coverage   53.2223%   55.1772%   +1.9549%     
================================================
  Files           213       1002       +789     
  Lines         17720     137399    +119679     
================================================
+ Hits           9431      75813     +66382     
- Misses         7686      56045     +48359     
- Partials        603       5541      +4938     

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Nov 19, 2024

/hold
waiting #11743

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2024
Copy link
Contributor

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 21, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, D3Hunter

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 21, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 21, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-21 03:03:37.629797049 +0000 UTC m=+87205.249451562: ☑️ agreed by Benjamin2037.
  • 2024-11-21 03:11:52.869611748 +0000 UTC m=+87700.489266259: ☑️ agreed by D3Hunter.

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 28, 2024
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Nov 28, 2024

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 28, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 28, 2024

@GMHDBJD: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
jenkins-ticdc/verify daaec12 link true /test verify
pull-cdc-integration-storage-test daaec12 link true /test cdc-integration-storage-test
pull-cdc-integration-mysql-test daaec12 link true /test cdc-integration-mysql-test
pull-cdc-integration-pulsar-test daaec12 link true /test cdc-integration-pulsar-test
pull-cdc-integration-kafka-test daaec12 link true /test cdc-integration-kafka-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dm Issues or PRs related to DM. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refine code
3 participants