Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug(ticdc): add more logs to the kafka sink and enable sarama log #11815

Merged

Conversation

3AceShowHand
Copy link
Contributor

@3AceShowHand 3AceShowHand commented Dec 2, 2024

What problem does this PR solve?

Issue Number: close #11823

What is changed and how it works?

  • add logs to the kafka sink before send out the message
  • replace sarama by a custom sarama branch, add more log if retry happens
  • add logs to the kafka sink when receive response and detect if commit-ts regressed

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 2, 2024
@3AceShowHand 3AceShowHand changed the title [DNM] test some special order problem debug(ticdc): test some special order problem Dec 4, 2024
@3AceShowHand 3AceShowHand changed the title debug(ticdc): test some special order problem debug(ticdc): add more logs to the kafka sink and enable sarama log Dec 4, 2024
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Dec 4, 2024
@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand 3AceShowHand changed the base branch from release-7.5 to release-7.5-20241204-v7.5.4 December 4, 2024 06:33
Copy link
Contributor

ti-chi-bot bot commented Dec 4, 2024

@flowbehappy: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 4, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 4, 2024
@3AceShowHand
Copy link
Contributor Author

/retest

@wk989898
Copy link
Collaborator

wk989898 commented Dec 5, 2024

/retest

1 similar comment
@wk989898
Copy link
Collaborator

wk989898 commented Dec 5, 2024

/retest

@3AceShowHand
Copy link
Contributor Author

/test engine-integration-test

@wk989898
Copy link
Collaborator

wk989898 commented Dec 5, 2024

/retest

1 similar comment
@jebter
Copy link

jebter commented Dec 5, 2024

/retest

Copy link
Contributor

ti-chi-bot bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CharlesCheung96, flowbehappy, lance6716, wk989898

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 5, 2024
@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/test cdc-integration-mysql-test

@3AceShowHand
Copy link
Contributor Author

/retest

1 similar comment
@wk989898
Copy link
Collaborator

wk989898 commented Dec 5, 2024

/retest

@wk989898
Copy link
Collaborator

wk989898 commented Dec 5, 2024

/test engine-integration-test

@ti-chi-bot ti-chi-bot bot merged commit aeafa81 into pingcap:release-7.5-20241204-v7.5.4 Dec 5, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dm Issues or PRs related to DM. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants