Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dm-test: fix unstable case #3365

Merged
merged 2 commits into from
Nov 10, 2021
Merged

dm-test: fix unstable case #3365

merged 2 commits into from
Nov 10, 2021

Conversation

D3Hunter
Copy link
Contributor

@D3Hunter D3Hunter commented Nov 10, 2021

What problem does this PR solve?

fix unstable case here

What is changed and how it works?

run command with retry

reason see this

Check List

Tests

  • No code

Release note

`None`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 10, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Ehco1996
  • glorv

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. contribution This PR is from a community contributor. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 10, 2021
@D3Hunter
Copy link
Contributor Author

/run-dm-integration-test

@D3Hunter D3Hunter marked this pull request as ready for review November 10, 2021 07:31
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 10, 2021
@D3Hunter
Copy link
Contributor Author

@lance6716 PTAL

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 10, 2021
@D3Hunter
Copy link
Contributor Author

/run-dm-compatibility-test
/run-integration-test
/run-kafka-integration-test

@lance6716
Copy link
Contributor

I prefer we update the error message as well

https://github.com/pingcap/ticdc/blob/e052c6aa1878130fccc296be861a4e8201cfcaac/dm/pkg/terror/error_list.go#L792

and maybe we can let Relay unit implement a WaitUntil in future PRs (please help file an issue)

https://github.com/pingcap/ticdc/blob/e052c6aa1878130fccc296be861a4e8201cfcaac/dm/dm/worker/subtask.go#L629

@codecov-commenter
Copy link

Codecov Report

Merging #3365 (9f93e26) into master (24030f8) will increase coverage by 0.3534%.
The diff coverage is 61.8229%.

@@               Coverage Diff                @@
##             master      #3365        +/-   ##
================================================
+ Coverage   56.5356%   56.8890%   +0.3534%     
================================================
  Files           211        221        +10     
  Lines         22798      23022       +224     
================================================
+ Hits          12889      13097       +208     
- Misses         8598       8605         +7     
- Partials       1311       1320         +9     

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 10, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 10, 2021
@overvenus
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9f93e26

@Ehco1996
Copy link
Contributor

I prefer we update the error message as well

https://github.com/pingcap/ticdc/blob/e052c6aa1878130fccc296be861a4e8201cfcaac/dm/pkg/terror/error_list.go#L792

and maybe we can let Relay unit implement a WaitUntil in future PRs (please help file an issue)

https://github.com/pingcap/ticdc/blob/e052c6aa1878130fccc296be861a4e8201cfcaac/dm/dm/worker/subtask.go#L629

we can disscuss this later, quick merge this pr for CI 😅😅

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 10, 2021
@Ehco1996
Copy link
Contributor

/merge

@Ehco1996
Copy link
Contributor

/run-dm-integration-tests
/run-unit-test

@ti-chi-bot
Copy link
Member

@D3Hunter: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lance6716 lance6716 added the area/dm Issues or PRs related to DM. label Nov 10, 2021
@ti-chi-bot ti-chi-bot merged commit 7fcc0c8 into pingcap:master Nov 10, 2021
@D3Hunter D3Hunter deleted the fix-unstable-case branch November 10, 2021 11:26
glorv pushed a commit to glorv/ticdc that referenced this pull request Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dm Issues or PRs related to DM. contribution This PR is from a community contributor. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants