Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix binlog 999999 #4773

Merged
merged 11 commits into from
Mar 7, 2022
Merged

test: fix binlog 999999 #4773

merged 11 commits into from
Mar 7, 2022

Conversation

GMHDBJD
Copy link
Contributor

@GMHDBJD GMHDBJD commented Mar 4, 2022

What problem does this PR solve?

Issue Number: ref #4287

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 4, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • WizardXiao
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 4, 2022
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 4, 2022
@GMHDBJD GMHDBJD added status/ptal Could you please take a look? component/test Unit tests and integration tests component. area/dm Issues or PRs related to DM. labels Mar 4, 2022
@GMHDBJD GMHDBJD requested a review from WizardXiao March 4, 2022 06:25
@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2022 •
edited
Loading

Codecov Report

Merging #4773 (907cbb6) into master (9607554) will decrease coverage by 0.1380%.
The diff coverage is 51.8176%.

Flag Coverage Δ
cdc 59.6672% <51.8176%> (-0.2551%) ⬇️
dm 52.0545% <ø> (+0.0256%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #4773        +/-   ##
================================================
- Coverage   55.6402%   55.5022%   -0.1381%     
================================================
  Files           494        521        +27     
  Lines         61283      64365      +3082     
================================================
+ Hits          34098      35724      +1626     
- Misses        23750      25121      +1371     
- Partials       3435       3520        +85

@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 4, 2022
@GMHDBJD
Revert "test url"
9f0e51d 
This reverts commit 760f471.
@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 4, 2022
WizardXiao
WizardXiao reviewed Mar 4, 2022
View reviewed changes
Copy link
Contributor

@WizardXiao WizardXiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 4, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 4, 2022
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Mar 4, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9f0e51d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 4, 2022
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Mar 4, 2022

/run-integration-test /tikv=pr/12050
/run-kafka-integration-test /tikv=pr/12050

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Mar 4, 2022

/merge

1 similar comment
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Mar 7, 2022

/merge

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Mar 7, 2022

/merge

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Mar 7, 2022

/merge

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Mar 7, 2022

/run-integration-test

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Mar 7, 2022

/run-kafka-integration-test

@ti-chi-bot
Copy link
Member

@GMHDBJD: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lance6716
Copy link
Contributor

/run-leak-test

@ti-chi-bot ti-chi-bot merged commit cd07918 into pingcap:master Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WizardXiao WizardXiao WizardXiao approved these changes

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
area/dm Issues or PRs related to DM. component/test Unit tests and integration tests component. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look?
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GMHDBJD @ti-chi-bot @codecov-commenter @lance6716 @WizardXiao