Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend, infosync: optimize TestHandlerReturnError and TestEtcdServerDown4Sync #398

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

djshow832
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #374

Problem Summary:

  • TestHandlerReturnError takes 15s
  • TestEtcdServerDown4Sync takes 17s

What is changed and how it works:

  • Add ConnectTime to BCConfig so I can make the timeout shorter in TestHandlerReturnError. I prefer not to put it into configuration because connection timeout barely happens in self-hosted deployment.
  • Reduce loops from 5 to 1 for TestEtcdServerDown4Sync.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot requested review from bb7133 and xhebox November 10, 2023 10:15
@ti-chi-bot ti-chi-bot bot added the size/M label Nov 10, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 13, 2023
Copy link

ti-chi-bot bot commented Nov 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Nov 13, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-13 02:32:19.730376111 +0000 UTC m=+4043537.317486241: ☑️ agreed by xhebox.

@ti-chi-bot ti-chi-bot bot added the approved label Nov 13, 2023
@ti-chi-bot ti-chi-bot bot merged commit b8ce9c0 into pingcap:main Nov 13, 2023
6 checks passed
@djshow832 djshow832 deleted the optimize_test branch November 13, 2023 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize TestHandlerReturnError
2 participants