Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy: remove sequence check #410

Merged
merged 10 commits into from
Dec 22, 2023
Merged

proxy: remove sequence check #410

merged 10 commits into from
Dec 22, 2023

Conversation

xhebox
Copy link
Collaborator

@xhebox xhebox commented Dec 1, 2023

What problem does this PR solve?

Issue Number: close #409

Problem Summary: Remove sequence checks.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot requested review from bb7133 and djshow832 December 1, 2023 08:46
@ti-chi-bot ti-chi-bot bot added the size/L label Dec 1, 2023
Signed-off-by: xhe <[email protected]>
Signed-off-by: xhe <[email protected]>
pkg/proxy/backend/authenticator.go Outdated Show resolved Hide resolved
pkg/proxy/backend/error.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added size/S and removed size/L labels Dec 1, 2023
@xhebox xhebox requested a review from djshow832 December 1, 2023 09:42
Signed-off-by: xhe <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/M and removed size/S labels Dec 1, 2023
@xhebox xhebox requested a review from djshow832 December 22, 2023 05:21
@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 22, 2023
Copy link

ti-chi-bot bot commented Dec 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djshow832

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Dec 22, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-22 06:30:05.363363025 +0000 UTC m=+1201696.400589942: ☑️ agreed by djshow832.

@ti-chi-bot ti-chi-bot bot added the approved label Dec 22, 2023
@ti-chi-bot ti-chi-bot bot merged commit 1a29ee5 into pingcap:main Dec 22, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove sequence check
2 participants