Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics, router: add more metrics #416

Merged
merged 6 commits into from
Dec 22, 2023
Merged

Conversation

djshow832
Copy link
Collaborator

@djshow832 djshow832 commented Dec 18, 2023

What problem does this PR solve?

Issue Number: ref #406

Problem Summary:
We still need more metrics for troubleshooting.

What is changed and how it works:

  • Add metrics Create Connection OPM, Disconnection OPM, P99 Duration By Instance, P99 Duration By Backend, and Health Check Cycle.
  • Change metrics from Session Migrations to Session Migration OPM.
  • Remove metrics Get Backend Count because most of the time it's useless.
  • Update the health check cycle: no need to wait for 2 seconds every time.
  • Update getting backend IO log: log a warning when the duration is above 1s.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

image

image

image

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot requested review from bb7133 and xhebox December 18, 2023 10:32
@ti-chi-bot ti-chi-bot bot added the size/XL label Dec 18, 2023
@ti-chi-bot ti-chi-bot bot added size/XXL and removed size/XL labels Dec 19, 2023
Copy link

ti-chi-bot bot commented Dec 21, 2023

@djshow832: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-mysql-test 0856a85 link true /test pull-mysql-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

ti-chi-bot bot commented Dec 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 22, 2023
Copy link

ti-chi-bot bot commented Dec 22, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-22 06:49:02.212367839 +0000 UTC m=+1202833.249594765: ☑️ agreed by xhebox.

@ti-chi-bot ti-chi-bot bot added the approved label Dec 22, 2023
@ti-chi-bot ti-chi-bot bot merged commit f64bde1 into pingcap:main Dec 22, 2023
5 checks passed
@djshow832 djshow832 deleted the enhance_metrics branch December 22, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants