-
Couldn't load subscription status.
- Fork 32
Remove deprecated flags #854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #854 +/- ##
=======================================
Coverage ? 67.23%
=======================================
Files ? 129
Lines ? 12260
Branches ? 0
=======================================
Hits ? 8243
Misses ? 3435
Partials ? 582
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll hold this PR because it breaks compatibility. Some tools may have added these options. It makes them unable to start without removing the options.
|
/hold |
|
Do we now which tools might use these? TiUP Cluster? TiUP Playground? TiDB Operator? Maybe we should try go get those fixed as the options currently don't do anything. Should we add some warnings/errors on stderr if anyone calls |
What problem does this PR solve?
Problem Summary:
What is changed and how it works:
This was deprecated on Fri Apr 12 10:00:22 2024 +0800 by #504
Check List
Tests
Notable changes
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.