Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add agg mode to fix read tifalsh fail #2793

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Add agg mode to fix read tifalsh fail #2793

merged 2 commits into from
Nov 8, 2024

Conversation

shiyuhang0
Copy link
Member

@shiyuhang0 shiyuhang0 commented Nov 7, 2024 •
edited
Loading

What problem does this PR solve?

reproduce step:

  1. create table test.t(id int not null);
  2. alter table test.t set tiflash replica 1;
  3. Execute tispark
spark.conf.set("spark.tispark.isolation_read_engines", "tiflash")
spark.sql("select max(id) from tidb_catalog.test.t").show()
  1. output error
can not convert NULL value to non-Nullable type

What is changed and how it works?

update tipb proto and set AggFunctionMode to Partial1Mode

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the tidb-ansible repository
  • Need to be included in the release note

@ti-chi-bot ti-chi-bot bot requested a review from zhangyangyu November 7, 2024 10:22
@ti-chi-bot ti-chi-bot bot added the size/S label Nov 7, 2024
windtalker
windtalker approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 7, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-07 11:10:48.543136146 +0000 UTC m=+1125761.382291692: ☑️ agreed by windtalker.

@ti-chi-bot ti-chi-bot bot added the approved label Nov 7, 2024
@shiyuhang0
Copy link
Member Author

/run-all-tests tidb=release-6.5 tikv=release-6.5 pd=release-6.5

5 similar comments
@shiyuhang0
Copy link
Member Author

/run-all-tests tidb=release-6.5 tikv=release-6.5 pd=release-6.5

@shiyuhang0
Copy link
Member Author

/run-all-tests tidb=release-6.5 tikv=release-6.5 pd=release-6.5

@shiyuhang0
Copy link
Member Author

/run-all-tests tidb=release-6.5 tikv=release-6.5 pd=release-6.5

@shiyuhang0
Copy link
Member Author

/run-all-tests tidb=release-6.5 tikv=release-6.5 pd=release-6.5

@shiyuhang0
Copy link
Member Author

/run-all-tests tidb=release-6.5 tikv=release-6.5 pd=release-6.5

@shiyuhang0 shiyuhang0 merged commit 7a0e940 into pingcap:release-3.1 Nov 8, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windtalker windtalker windtalker approved these changes

@zhangyangyu zhangyangyu Awaiting requested review from zhangyangyu

Assignees
No one assigned
Labels
approved needs-1-more-lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shiyuhang0 @windtalker