Add code for large amount of users creation and few recommendations #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinheadmz
reviewed
Jul 22, 2024
There was a problem hiding this comment.
Thanks for your work on this! I have to apologize, I had a bulk-user function implemented already (I needed it for BTCFOSS in January) but I didn't push it to the repository. That's now on master branch in a2e5e98
I started reviewing this PR and left a some nits in the English before I realized we'd duplicated work. Take a look at the --n option I wrote and let me know if this satisfies your use case as well
| - Optionally add `-signet`, etc for different network | ||
| - Start proxy server: `python src/server.py main` | ||
| - Optionally replace `main` with `signet`, etc. | ||
| - Use `nohup` or `tmux` to ensure that the server process is not killed when exiting the terminal or session. |
There was a problem hiding this comment.
should go before "start proxy server" and indicate its optional.
| @@ -34,6 +36,15 @@ Password for newuser1: lYDk7mbTiN60 | |||
| ~/rpc-auth-proxy$ python src/users.py newuser2 -p hunter2 | |||
| Password for newuser2: hunter2 | |||
| ``` | |||
| ### Large amount of Users ### | |||
| Another utility that you can use for adding large amount of users it's `src/bulk_users.py`. Hashed passwords are saved by | |||
| default in a JSON file at `~/.rpc-auth-proxy-passwords.json`, but another file is saved too with the pair of username and clear password. | |||
There was a problem hiding this comment.
whats the other files name and path?
Co-authored-by: Matthew Zipkin <[email protected]>
Co-authored-by: Matthew Zipkin <[email protected]>
Co-authored-by: Matthew Zipkin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Extend code for User/Password creation: Implemented functionality to create a large number of users and their corresponding passwords.
Recommendations in Install and Run sections:
nohuportmux: Suggested usingnohuportmuxto run long processes without interruption.