Skip to content

Commit

Permalink
more
Browse files Browse the repository at this point in the history
  • Loading branch information
AlbertCarreras committed Oct 18, 2024
1 parent 4d56faf commit d536bd4
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 8 deletions.
4 changes: 3 additions & 1 deletion packages/gestalt/src/SelectList.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,8 @@ function SelectList({
formElement.base,
size === 'md' ? layout.medium : layout.large,
{
[styles.placeholder]: !disabled && !value,
[styles.selected]: !disabled && !!value,
[styles.enabled]: !disabled,
[formElement.md]: size === 'md',
[formElement.lg]: size === 'lg',
Expand Down Expand Up @@ -223,7 +225,7 @@ function SelectList({
value={showPlaceholder ? placeholder : value}
>
{showPlaceholder && (
<option className={classnames(styles.option)} disabled hidden value={placeholder}>
<option disabled hidden value={placeholder}>
{placeholder}
</option>
)}
Expand Down
5 changes: 1 addition & 4 deletions packages/gestalt/src/SelectList/SelectListOption.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
import classnames from 'classnames';
import styles from '../SelectList.css';

type Props = {
/**
* Used to disable the option.
Expand All @@ -21,7 +18,7 @@ type Props = {
*/
export default function SelectListOption({ disabled, label, value }: Props) {
return (
<option className={classnames(styles.option)} disabled={disabled} value={value}>
<option disabled={disabled} value={value}>
{label}
</option>
);
Expand Down
6 changes: 3 additions & 3 deletions packages/gestalt/src/__snapshots__/SelectList.test.tsx.snap
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ exports[`SelectList renders an option group 1`] = `
</div>
<select
aria-invalid="false"
className="select base medium md normal enabledTransparent"
className="select base medium placeholder enabled md normal"
disabled={false}
id="optionGroup"
onBlur={[Function]}
Expand Down Expand Up @@ -145,7 +145,7 @@ exports[`SelectList renders with a hidden label 1`] = `
</div>
<select
aria-invalid="false"
className="select base medium md normal enabledTransparent"
className="select base medium placeholder enabled md normal"
disabled={false}
id="test"
onBlur={[Function]}
Expand Down Expand Up @@ -210,7 +210,7 @@ exports[`SelectList renders with typical props 1`] = `
</div>
<select
aria-invalid="false"
className="select base medium md normal enabledTransparent"
className="select base medium placeholder enabled md normal"
disabled={false}
id="test"
onBlur={[Function]}
Expand Down

0 comments on commit d536bd4

Please sign in to comment.