Avatar/AvatarGroup: VR Implementation Changes #3765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for gestalt ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
author Sarah Alli <[email protected]> 1726758738 -0400 committer Sarah Alli <[email protected]> 1727819323 -0400 avatar vr changes separated css from avatargroup and avatar avatar group prop drilling updated snapshots added internal props fixed avatar group props added avatarColorIndex updated example changed keys fixed typing colors working text ui working replaced original foundation layer for classic fixed fixed colors prettier fixed focus outline git adfixed container fixing docs fixed prop naming working on docs building examples added more VR examples changed colors on examples updated images fixed pressed state cleanup examples fixed removed focus from regular avatar updated AvatarGroup examples prettier small fixes snapshot snapshots snapshots dark mode support for temp color values
fixed outline small fixes adjusted prop naming examples fix
| ref, | ||
| ) { | ||
| const [hovered, setHovered] = useState(false); | ||
| size = isInVRExperiment ? 'md' : 'fit', |
There was a problem hiding this comment.
this is risky but we'll give it a shot.
AlbertCarreras
approved these changes
Oct 3, 2024
AlbertCarreras
added
minor release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avatar/AvatarGroup: VR Implementation Changes #3765
AVATAR
AVATARGROUP