Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon: Update Icons [GESTALT-8440] #3766

Merged
merged 6 commits into from
Sep 24, 2024

Conversation

rlingineni
Copy link
Contributor

@rlingineni rlingineni commented Sep 19, 2024

Pull Request Instructions

Introducing new icons.

This also updates the icon component to swap the icon if list-numbered is used because it needs a specific RTL icon

Diff

Interactive differences in the PR are available to see here.

Classic Icons
VR Icons

New Icons Introduced

line-logo
wechat
viber
skype
snapchat
reddit
kakao-talk
telegram
pincode
indent
outdent
list-numbered
list-numbered-rtl
gift

Classic
VR

Links

  • Jira
  • [TDD](link to Paper doc)
  • [Figma](link to Figma file)

Checklist

  • Added unit tests
  • Added documentation + accessibility tests
  • Verified accessibility: keyboard & screen reader interaction
  • Checked dark mode, responsiveness, and right-to-left support
  • Checked stakeholder feedback (e.g. Gestalt designers, relevant feature teams)

@rlingineni rlingineni requested a review from a team as a code owner September 19, 2024 19:01
@rlingineni rlingineni changed the title Icon: Update Icons [GESTALT-8366] Icon: Update Icons [GESTALT-8440] Sep 19, 2024
@rlingineni rlingineni added the minor release Minor release label Sep 19, 2024
Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for gestalt ready!

Name Link
🔨 Latest commit 661c900
🔍 Latest deploy log https://app.netlify.com/sites/gestalt/deploys/66f322f649c88400087fdb8b
😎 Deploy Preview https://deploy-preview-3766--gestalt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AlbertCarreras
Copy link
Contributor

AlbertCarreras commented Sep 19, 2024

Why are we reintroducing pincode? there were no usages in any platform.

we were only using colored one. are we going to deprecate colored one?
Screenshot by Dropbox Capture

with all these new ones, are we going to remove all custom svgs?
Screenshot by Dropbox Capture

@rlingineni rlingineni enabled auto-merge (squash) September 24, 2024 20:45
@rlingineni rlingineni merged commit 13abce5 into pinterest:master Sep 24, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor release Minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants