Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchGuide: Fixes and docs improvements #3801

Merged

Conversation

eniomoura
Copy link
Contributor

Summary

What changed?

Added fixes recommended in the PR #3772 and other fixes encountered.
Mostly code organization and docs improvements to SearchGuide.
This PR is dependant on #3799 for CSS changes, and includes it.

Why?

To improve component quality.

@eniomoura eniomoura changed the title Searchguide docs nits fixes SearchGuide: Fixes and docs improvements Oct 10, 2024
@eniomoura eniomoura added the minor release Minor release label Oct 10, 2024
Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for gestalt ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 591c899
🔍 Latest deploy log https://app.netlify.com/sites/gestalt/deploys/670fbf21503811000894ede8
😎 Deploy Preview https://deploy-preview-3801--gestalt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@eniomoura eniomoura marked this pull request as ready for review October 15, 2024 19:51
@eniomoura eniomoura requested a review from a team as a code owner October 15, 2024 19:51
@AlbertCarreras
Copy link
Contributor

AlbertCarreras commented Oct 16, 2024

Reuse the image src form Avatar, they look more modern.
Screenshot by Dropbox Capture
Screenshot by Dropbox Capture

@AlbertCarreras
Copy link
Contributor

AlbertCarreras commented Oct 16, 2024

This one flickers, can you check if it's implementation of example or the code?
Brave Browser - SearchGuide - Gestalt 2024-10-16 at 3 25 10 AM

@AlbertCarreras AlbertCarreras merged commit d67c7bb into pinterest:master Oct 16, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor release Minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants