-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SearchGuide: Fixes and docs improvements #3801
Merged
AlbertCarreras
merged 7 commits into
pinterest:master
from
eniomoura:searchguide-docs-nits-fixes
Oct 16, 2024
Merged
SearchGuide: Fixes and docs improvements #3801
AlbertCarreras
merged 7 commits into
pinterest:master
from
eniomoura:searchguide-docs-nits-fixes
Oct 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eniomoura
changed the title
Searchguide docs nits fixes
SearchGuide: Fixes and docs improvements
Oct 10, 2024
✅ Deploy Preview for gestalt ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
…e-docs-nits-fixes
AlbertCarreras
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What changed?
Added fixes recommended in the PR #3772 and other fixes encountered.
Mostly code organization and docs improvements to SearchGuide.
This PR is dependant on #3799 for CSS changes, and includes it.
Why?
To improve component quality.