Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka AMI promotion workflow by Orion #250

Merged
merged 10 commits into from
Feb 1, 2024

Conversation

brunoasr
Copy link
Contributor

Summary

AMI promotion workflow:

A strategy using a tag in AMIs named application_environment has been developed for Kafka clusters to allow automatic selection of the latest AMI for a given environment.
This PR complements it by implementing a UI to manage this tag.

  1. In the homepage, user selects tab AMI. A list of 4 tags is displayed, two of them fixed (application=kafka and application_environment=* - must exist) and two of them selectable with dropdown menus: OS and CPU Architecture. User selects OS and/or CPU Architecture accordingly and clicks Apply button.
  2. Based on the tags selected, a list of available AMIs (limited to images created in the last 180 days) is retrieved from the cloud provider. It displays 3 columns: AMI Id, tag application_environment and Creation Date.
  3. User selects an image from the list. Tag application_environment is displayed in a text field on the right, and decoded to a group of checkboxes, one for each environment.
  4. User manipulates the tag value using the checkboxes. When ready they click Update button to update the tag.

Test Plan

@brunoasr brunoasr requested a review from a team as a code owner December 28, 2023 23:15
Copy link
Contributor

@vahidhashemian vahidhashemian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the earlier comments. One more comment inline.

@vahidhashemian vahidhashemian merged commit b8cd232 into pinterest:master Feb 1, 2024
1 check passed
@brunoasr brunoasr deleted the ami_tag_manager branch February 21, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants