Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update node recovery check timeout values #287

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Update node recovery check timeout values #287

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions orion-server/src/main/java/com/pinterest/orion/core/actions/generic/NodeAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ public abstract class NodeAction extends Action {

public static final String POSTHEALTHCHECK_INTERVAL = "postHealthcheckInterval";
public static final String RECOVERY_TIMEOUT = "recoveryTimeout";
private static final int DEFAULT_RECOVERY_TIMEOUT_MS = 1800_000; // 30 minutes
private static final int DEFAULT_HEALTHCHECK_INTERVAL_MS = 10_000; // 10 seconds

enum MaintenancePolicy {
NONE,
Expand Down Expand Up @@ -151,8 +153,8 @@ protected void postActionValidation() throws Exception {

public void checkAndWaitForNodeToRecover() throws TimeoutException {
long completeTime = System.currentTimeMillis();
int timeout = 60_000;
int healthCheckInterval = 10_000;
int timeout = DEFAULT_RECOVERY_TIMEOUT_MS;
int healthCheckInterval = DEFAULT_HEALTHCHECK_INTERVAL_MS;
if (containsAttribute(RECOVERY_TIMEOUT)) {
timeout = getAttribute(RECOVERY_TIMEOUT).getValue();
}
Expand Down
Loading