Generate and publish ClickHouse node configs #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Whenever new servers are added to or removed from a ClickHouse cluster, each node has to go with a new config specifying the updated list of replica servers for each shard.
This PR helps to simplify that process by automatically generating the config for each ClickHouse node from a given template config by:
Once generated, Orion server will then publish the configs for each node to the given S3 bucket under the path
<node_hostname>/config.xml. It is expected that the Orion agent will then pull the config for a specific node as needed.Test
Ran Orion server against local Docker ClickHouse cluster (see testing section here), and made sure that the correct config has been generated and pushed to the S3 bucket.