-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding initial commit for the blocking functionality in the get func… #535
Open
JoJo10Smith
wants to merge
4
commits into
pinterest:master
Choose a base branch
from
JoJo10Smith:blocking
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
3c1e497
Adding initial commit for the bloacking functionality in the get func…
JoJo10Smith 6b3a5bd
Reimplemented the blocking logic to have minimal user inputs: timeout…
JoJo10Smith a78817e
added the now component within the loop to always update the time tha…
JoJo10Smith 97d1dcf
Correcting linting errors to comply with flake8
JoJo10Smith File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -72,17 +72,27 @@ def get_and_release(self, destroy_on_fail=False) -> Iterator[T]: | |
raise | ||
self.release(obj) | ||
|
||
def get(self): | ||
def get(self, **options): | ||
# get the current time in seconds and the maximum time we can run the function until | ||
current_time = time.time() | ||
end_time = current_time + max(options.get('timeout', 0), 0) | ||
|
||
with self._lock: | ||
# while there are free objects or we are before the time limit | ||
# Find a free object, removing any that have idled for too long. | ||
now = self._idle_clock() | ||
while self._free_objs: | ||
obj = self._free_objs.popleft() | ||
if now - obj._last_used <= self.idle_timeout: | ||
break | ||
|
||
if self._after_remove is not None: | ||
self._after_remove(obj) | ||
while current_time <= end_time: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if I understand this correctly this results in busy waiting all while holding a lock. Which seems like a behavior we don't want to introduce. |
||
# get the current time again to check if we can run another iteration | ||
current_time = time.time() | ||
now = self._idle_clock() | ||
|
||
while self._free_objs: | ||
obj = self._free_objs.popleft() | ||
if now - obj._last_used <= self.idle_timeout: | ||
break | ||
|
||
if self._after_remove is not None: | ||
self._after_remove(obj) | ||
|
||
else: | ||
# No free objects, create a new one. | ||
curr_count = len(self._used_objs) | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use keyword arguments with defaults here? That and a docstring will make this feature easier to find and documented in our code docs.