Skip to content

Commit

Permalink
Revert "Revert "[Backport][Ray Dashboard] make memory profile href li…
Browse files Browse the repository at this point in the history
…nk relat…" (#25)

Reverts #23

Re-adds logic of the base PR
  • Loading branch information
votrou authored Oct 8, 2024
1 parent 3895456 commit 994bc03
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions dashboard/client/src/common/ProfilingLink.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,7 @@ export const MemoryProfilingButton = ({
if (!pid || !ip) {
return <div></div>;
}
const profilerUrl = `/memory_profile?pid=${pid}&ip=${ip}`;
const profilerUrl = `memory_profile?pid=${pid}&ip=${ip}`;

return <ProfilerButton profilerUrl={profilerUrl} type={type} />;
};
Expand All @@ -325,7 +325,7 @@ export const TaskMemoryProfilingButton = ({
if (!taskId) {
return null;
}
const profilerUrl = `/memory_profile?task_id=${taskId}&attempt_number=${attemptNumber}&node_id=${nodeId}`;
const profilerUrl = `memory_profile?task_id=${taskId}&attempt_number=${attemptNumber}&node_id=${nodeId}`;

return <ProfilerButton profilerUrl={profilerUrl} />;
};

0 comments on commit 994bc03

Please sign in to comment.