Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport ray 2.36.0] Fix arrow_parquet_args #31

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

alexwang177
Copy link

@alexwang177 alexwang177 commented Dec 6, 2024

Why are these changes needed?

Copy change from OSS fix. ray-project#47161

This allows us to correctly pass in arrow_parquet_args when calling ray.data.write_parquet. Most notably, this means we can write ZSTD compressed parquet files.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@alexwang177 alexwang177 marked this pull request as ready for review December 6, 2024 22:05
@alexwang177 alexwang177 changed the title copy changes from OSS fix Fix arrow_parquet_args Dec 6, 2024
@alexwang177 alexwang177 merged commit 16329e2 into pinterest/main-2.10.0 Dec 9, 2024
1 check passed
@alexwang177 alexwang177 changed the title Fix arrow_parquet_args [Backport ray 2.36.0] Fix arrow_parquet_args Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants