Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix backup failure due to case-sensitive table name conflict #13

Merged

Conversation

saahilbarai
Copy link

@saahilbarai saahilbarai commented Sep 25, 2024

Why I'm doing:

Cherry picking bug fix from main StarRocks branch into the pinterest 3.3 branch.

I am making this change due to fix an issue where two table names with the same name but differing case throws a semantic error citing duplicated tables for the backup process.

What I'm doing:

Amending the usage of a case insensitive tree map used to process both the backup and restore process in favor of a case sensitive tree map.

Fixes #issue
StarRocks#50949

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@saahilbarai saahilbarai marked this pull request as ready for review September 25, 2024 18:10
@saahilbarai saahilbarai merged commit cd7579e into pinterest-integration-3.3 Sep 25, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants