Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(annotations): Update annotations UI to display label as tooltip on hover #27

Merged
merged 4 commits into from
Apr 8, 2024

Conversation

kgopal492
Copy link

SUMMARY

  • Update annotation UI to show tooltip on hover rather than using label to improve readability.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before

Screenshot 2024-04-02 at 5 20 12 PM

After

Screenshot 2024-04-02 at 5 18 00 PM

TESTING INSTRUCTIONS

Add annotation layer to chart, and view.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 15.78947% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 56.33%. Comparing base (6e4d1f5) to head (91c3c8e).

Files Patch % Lines
...ugins/plugin-chart-echarts/src/utils/annotation.ts 0.00% 10 Missing ⚠️
...lugin-chart-echarts/src/Timeseries/transformers.ts 0.00% 2 Missing ⚠️
superset/initialization/__init__.py 33.33% 2 Missing ⚠️
superset/models/core.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##           pinterest-release-2.1      #27      +/-   ##
=========================================================
- Coverage                  56.34%   56.33%   -0.01%     
=========================================================
  Files                       1886     1886              
  Lines                      72718    72729      +11     
  Branches                    7891     7893       +2     
=========================================================
  Hits                       40973    40973              
- Misses                     29722    29733      +11     
  Partials                    2023     2023              
Flag Coverage Δ
javascript 53.88% <0.00%> (-0.02%) ⬇️
presto 52.66% <42.85%> (ø)
python 58.96% <42.85%> (ø)
unit 52.50% <14.28%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kgopal492 kgopal492 merged commit 21291ea into pinterest:pinterest-release-2.1 Apr 8, 2024
15 of 24 checks passed
kgopal492 added a commit that referenced this pull request May 6, 2024
…on hover (#27)

* Update annotations UI to display label as tooltip on hover
* fix annotation label overlap
* formatting
zhangvi7 pushed a commit that referenced this pull request Jul 15, 2024
…on hover (#27)

* Update annotations UI to display label as tooltip on hover
* fix annotation label overlap
* formatting
zhangvi7 pushed a commit that referenced this pull request Aug 1, 2024
…on hover (#27)

* Update annotations UI to display label as tooltip on hover
* fix annotation label overlap
* formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants