Migrate maven deploy to artifactory-push CLI (#1491)

* migrate to artifactory-push * move plugins outside of pluginManagement * cleanup * remove settings.xml * add comments --------- Co-authored-by: Jessica Chen <[email protected]>
pinterest · Mar 4, 2024 · fbb862b · fbb862b
1 parent c7407c7
commit fbb862b
Show file tree

Hide file tree

Showing 3 changed files with 43 additions and 29 deletions.
diff --git a/deploy-service/pom.xml b/deploy-service/pom.xml
@@ -106,19 +106,6 @@
         </plugins>
     </build>
 
-    <distributionManagement>
-        <repository>
-            <id>central</id>
-            <name>maven-releases</name>
-            <url>https://artifacts-prod-use1.pinadmin.com/artifactory/maven-private-prod-sox-local</url>
-        </repository>
-        <snapshotRepository>
-            <id>snapshots</id>
-            <name>maven-snapshots</name>
-            <url>https://artifacts-prod-use1.pinadmin.com/artifactory/maven-private-prod-sox-local</url>
-        </snapshotRepository>
-    </distributionManagement>
-
     <profiles>
         <profile>
             <id>coverage</id>

diff --git a/deploy-service/settings.xml b/deploy-service/settings.xml
diff --git a/deploy-service/universal/pom.xml b/deploy-service/universal/pom.xml
@@ -144,6 +144,9 @@
         <plugin>
           <artifactId>maven-deploy-plugin</artifactId>
           <version>2.8.2</version>
+          <configuration>  
+            <skip>true</skip>  
+          </configuration>
         </plugin>
         <plugin>
           <artifactId>maven-project-info-reports-plugin</artifactId>
@@ -164,6 +167,46 @@
           </execution>
         </executions>
       </plugin>
+      <plugin>
+        <!-- This is Pinterest deployment specific. -->
+        <!-- For non-Pinterest deployments, remove this block and use the maven-deploy-plugin instead. -->
+        <groupId>org.codehaus.mojo</groupId>
+        <artifactId>exec-maven-plugin</artifactId>
+        <version>3.0.0</version>  
+        <executions>
+          <execution>
+            <id>artifactory-push-deploy</id>
+            <phase>deploy</phase>
+            <goals>
+              <goal>exec</goal>
+            </goals>
+            <configuration>
+              <executable>artifactory-push</executable>
+              <arguments>
+                <argument>maven</argument>
+                <argument>--env</argument>
+                <argument>prod</argument>
+                <argument>--maven_type</argument>
+                <argument>${deployment.type}</argument>
+                <argument>--maven_group_id</argument>
+                <argument>${project.groupId}</argument>
+                <argument>--maven_artifact_id</argument>
+                <argument>${project.artifactId}</argument>
+                <argument>--maven_version</argument>
+                <argument>${project.version}</argument>
+                <argument>--maven_pom</argument>
+                <argument>${project.file.path}</argument>
+                <argument>--maven_jar</argument>
+                <argument>${project.build.directory}/${project.build.finalName}.jar</argument>
+                <argument>--maven_jar_src</argument>
+                <argument>${project.build.directory}/${project.build.finalName}-sources.jar</argument>
+                <argument>--to_repo</argument>
+                <argument>maven-private-prod-sox-local</argument>
+              </arguments>
+            </configuration>
+          </execution>
+        </executions>
+      </plugin>
     </plugins>
   </build>
 </project>