Update deploy agent logging #1258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the curl documentation:
-S, --show-error
When used with -s, --silent, it makes curl show an error message if it fails.
Add the flag to show the error in case of failures, which an be helpful
for debugging
Update the variable naming to describe the type in contains
When the sha1 reuqest for a build returns non-200, the verification is skipped. Since this happens often and is usually expected, switch to `log.warning`. Also, update the warning message to clarify the sha1 verification is skipped
In case of tarball extraction failures, log the exception and stack trace. These exceptions could cause the host to become stuck. The stack trace can help with debugging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains changes to improve debuggability such as:
Update error logging
In case of tarball extraction failures, log the exception and stack
trace. These exceptions could cause the host to become stuck. The stack
trace can help with debugging.
Update checksum verification warning
When the sha1 reuqest for a build returns non-200, the verification is
s. kipped.
Since this happens often and is usually expected, switch to
log.warning.Also, update the warning message to clarify the sha1 verification is
skipped
Add
Sflag to curlFrom the curl documentation:
-S, --show-error
When used with -s, --silent, it makes curl show an error message if it fails.
Add the flag to show the error in case of failures, which an be helpful
for debugging
Testing done:
Ran the downloader command locally. Verified it succeeded.
Also tested the error case by modifying the extracted dir and re-running the downloader. Ensured stack trace was logged