Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Container Health Status On Teletraan UI #1265

Merged
merged 4 commits into from
Sep 27, 2023

Conversation

liyaqin1
Copy link
Contributor

@liyaqin1 liyaqin1 commented Sep 22, 2023

Show Container Health Status On Teletraan UI
Related PR: #1260

@liyaqin1 liyaqin1 requested a review from a team as a code owner September 22, 2023 21:34
@liyaqin1 liyaqin1 changed the title store container health in the database Show Container Health Status On Teletraan UI Sep 27, 2023
@liyaqin1
Copy link
Contributor Author

Tested on devapp.
Here are the logs on deploy-agent side:

2023-09-27 18:36:04,306 urllib3.connectionpool:249 DEBUG Starting new HTTP connection (1): 127.0.0.1:8011
2023-09-27 18:36:04,375 urllib3.connectionpool:482 DEBUG http://127.0.0.1:8011 "POST /v1/system/ping HTTP/1.1" 200 294
2023-09-27 18:36:04,376 deployd.client.client:224 DEBUG PingRequest(hostId=i-0dd4b6ce5062c36f0, hostName=dev-yaqinli, hostIp=10.9.215.252, agentVersion=1.2.46-pinterest-1.0.2, autoscalingGroup=None, availabilityZone=us-east-1d, stageType=None, groups=['singer-prod-sidecar', 'envoy-devapp', 'tcollector-prod-sidecar', 'mcrouter-devapp', 'mcrouter-prod-sidecar', 'metrics-agent-prod-sidecar', 'zk_update_monitor-prod-sidecar'], accountId=998131032990, reports=PingReport(deployId=YINT0WznQEm_kLaUr9BGGQ, envId=nS2GIXkgQnK4pR9qG5ZpFg, deployStage=SERVING_BUILD, status=SUCCEEDED, errorCode=0, errorMessage=None, failCount=0, extraInfo=None, deployAlias=None, containerHealthStatus=None),PingReport(deployId=OPQeAZLxQlygFlmAZLewig, envId=inbDfs6KQICpRRfuKQw_bQ, deployStage=SERVING_BUILD, status=SUCCEEDED, errorCode=0, errorMessage=None, failCount=0, extraInfo=None, deployAlias=None, containerHealthStatus=None),PingReport(deployId=3zZuGjXbReqgsgwkAFcQPQ, envId=2XwshUOHR36DGEAH4PzBwg, deployStage=SERVING_BUILD, status=SUCCEEDED, errorCode=0, errorMessage=None, failCount=0, extraInfo=None, deployAlias=None, containerHealthStatus=healthy),PingReport(deployId=PfyxggJtQ9uD7yCgXUMtwA, envId=kwUx6aHWQo6R174lT-eawQ, deployStage=SERVING_BUILD, status=SUCCEEDED, errorCode=0, errorMessage=None, failCount=0, extraInfo=None, deployAlias=None, containerHealthStatus=None),PingReport(deployId=CDBJf7s1Sh2G7V1mZVPhpA, envId=typrFRIFR6-lDyaiNjAk9w, deployStage=SERVING_BUILD, status=SUCCEEDED, errorCode=0, errorMessage=None, failCount=0, extraInfo=None, deployAlias=None, containerHealthStatus=None),PingReport(deployId=rXqFmaubTIGROjX0XT4VAg, envId=gu2DEmL4Tv2XOqDKFc7Axw, deployStage=SERVING_BUILD, status=SUCCEEDED, errorCode=0, errorMessage=None, failCount=0, extraInfo=None, deployAlias=None, containerHealthStatus=None),PingReport(deployId=DcdD-aipRTKp4hmtmXg45g, envId=7ib3xSHSR3unnLdN-ViGxw, deployStage=SERVING_BUILD, status=SUCCEEDED, errorCode=0, errorMessage=None, failCount=0, extraInfo=None, deployAlias=None, containerHealthStatus=None),PingReport(deployId=QH71hZjfSn2MheO8nmMIkA, envId=pZwvW9faQTW7vD19ER72Gg, deployStage=SERVING_BUILD, status=SUCCEEDED, errorCode=0, errorMessage=None, failCount=0, extraInfo=None, deployAlias=None, containerHealthStatus=None),PingReport(deployId=stx01o7qQiKnKOFX2fL5Kg, envId=99xVHd7bSr608HSHqrCGbA, deployStage=SERVING_BUILD, status=SUCCEEDED, errorCode=0, errorMessage=None, failCount=0, extraInfo=None, deployAlias=None, containerHealthStatus=None),PingReport(deployId=qXyg0uh1RpeHfUiTHo_Q8g, envId=tLWOA1CsQ4W2Nu_kMFyYVA, deployStage=SERVING_BUILD, status=SUCCEEDED, errorCode=0, errorMessage=None, failCount=0, extraInfo=None, deployAlias=None, containerHealthStatus=None)) -> PingResponse(opCode=DELETE, deployGoal=DeployGoal(deployId=3zZuGjXbReqgsgwkAFcQPQ, envId=2XwshUOHR36DGEAH4PzBwg, envName=None, stageName=None, deployStage=SERVING_BUILD, build=None, deployAlias=None, agentConfig=None,scriptVariables=None, firstDeploy=False, isDocker=None))

And in the DB, the info for dev-yaqinli is updated successfully:

mysql> select host_name, container_health_status from agents;
+-----------------------------------------+-------------------------+
| host_name                               | container_health_status |
+-----------------------------------------+-------------------------+
| ip-10-1-209-41                          | N/A (Not Applicable)    |
| ip-10-1-209-41                          | N/A (Not Applicable)    |
| ip-10-1-209-41                          | N/A (Not Applicable)    |
| ip-10-1-209-41                          | N/A (Not Applicable)    |
| ip-10-1-209-41                          | N/A (Not Applicable)    |
| ip-10-1-209-41                          | N/A (Not Applicable)    |
| engprod-teletraan-service-dev1-0a019d94 | N/A (Not Applicable)    |
| engprod-teletraan-service-dev1-0a01dab5 | N/A (Not Applicable)    |
| dev-yaqinli                             | healthy                 |
| dev-yaqinli                             |                         |
| dev-yaqinli                             |                         |
| dev-yaqinli                             |                         |
| dev-yaqinli                             |                         |
| dev-yaqinli                             |                         |
| dev-yaqinli                             |                         |
| dev-yaqinli                             |                         |
| dev-yaqinli                             |                         |
| dev-yaqinli                             |                         |
+-----------------------------------------+-------------------------+
18 rows in set (0.00 sec)

mysql> 

Also, on UI, the info looks good to me:
Screenshot 2023-09-27 at 12 02 23 PM

Screenshot 2023-09-27 at 12 01 53 PM Screenshot 2023-09-27 at 12 02 35 PM

@liyaqin1 liyaqin1 merged commit d079d30 into master Sep 27, 2023
6 checks passed
@liyaqin1 liyaqin1 deleted the yaqin/showContainerStatusOnUI branch September 27, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants