Increase unit test coverage for changes in PR #1357 #1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzpcho
changed the title
gzpcho
changed the title
ntascii
reviewed
Dec 7, 2023
| @@ -13,6 +13,8 @@ | |||
| # limitations under the License. | |||
|
|
|||
| import unittest | |||
| from abc import ABCMeta, abstractmethod | |||
| from future.utils import with_metaclass | |||
There was a problem hiding this comment.
why we need this? the codebase is already py3.
There was a problem hiding this comment.
Left changing ABCMeta -> ABC to a separate PR. This test would cover that change to ensure the same functionality is preserved
ntascii
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unit tests to increase coverage of changes made in #1357
CDP-7321