Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add availability_zone in the ec2_tags #1370

Merged
merged 5 commits into from
Dec 20, 2023
Merged

Conversation

liyaqin1
Copy link
Contributor

@liyaqin1 liyaqin1 commented Dec 8, 2023

Related PR: #1340

@liyaqin1 liyaqin1 requested a review from a team as a code owner December 8, 2023 02:25
@liyaqin1
Copy link
Contributor Author

liyaqin1 commented Dec 8, 2023

Tested on my devapp.
Before the ec2_tags is:
ec2Tags={"Name": "dev-yaqinli", "devapp_version": "None", "service_mapping": "devapp", "usage_tag": "Dev Apps", "username": "yaqinli"}
Now the ec2_tags is:
ec2_tags: {"Name": "dev-yaqinli", "devapp_version": "None", "service_mapping": "devapp", "usage_tag": "Dev Apps", "username": "yaqinli", "availability_zone": "us-east-1d"}

@ntascii
Copy link
Contributor

ntascii commented Dec 19, 2023

can we update the info using availablityZone in PinRequest instead of using ec2 tags PingRequest(hostId=i-08211786ab8852f3c, hostName=helloworlddummyservice-server-u18-0a03fd62, hostIp=10.3.253.98, agentVersion=1.2.46-pinterest-1.0.2, autoscalingGroup=helloworlddummyservice-server-u18, availabilityZone=us-east-1e, stageType=latest, groups=['CMP',

@liyaqin1
Copy link
Contributor Author

can we update the info using availablityZone in PinRequest instead of using ec2 tags PingRequest(hostId=i-08211786ab8852f3c, hostName=helloworlddummyservice-server-u18-0a03fd62, hostIp=10.3.253.98, agentVersion=1.2.46-pinterest-1.0.2, autoscalingGroup=helloworlddummyservice-server-u18, availabilityZone=us-east-1e, stageType=latest, groups=['CMP',

On TAS side, we only handle the tags like this https://sourcegraph.pinadmin.com/github.com/pinterest/teletraan/-/blob/deploy-service/common/src/main/java/com/pinterest/deployservice/handler/PingHandler.java?L647:9
So, it is better to keep all ec2 tags in one place. Also, the tag name is availability_zone instead of availablityZone as you can see here:
Screenshot 2023-12-18 at 6 06 58 PM

ntascii
ntascii previously approved these changes Dec 20, 2023
@liyaqin1 liyaqin1 merged commit 332212b into master Dec 20, 2023
6 checks passed
@liyaqin1 liyaqin1 deleted the yaqin/addRegionInTags branch December 20, 2023 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants