Add metrics for first deploy success, provision latency #1426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerwowen
force-pushed
the
spr/master/8fdb7dc7
branch
from
4ef598e
to
3bc334c
Compare
tylerwowen
force-pushed
the
spr/master/9e058a5f
branch
from
a365d15
to
0346f13
Compare
ntascii
reviewed
Feb 1, 2024
deploy-service/common/src/main/java/com/pinterest/deployservice/handler/PingHandler.java
Outdated
Show resolved
Hide resolved
tylerwowen
force-pushed
the
spr/master/9e058a5f
branch
from
0346f13
to
641979b
Compare
tylerwowen
force-pushed
the
spr/master/8fdb7dc7
branch
from
3bc334c
to
cf1a80f
Compare
github-actions
bot
added
deploy-service
tylerwowen
changed the title
ntascii
previously approved these changes
Feb 5, 2024
tylerwowen
force-pushed
the
spr/master/9e058a5f
branch
from
641979b
to
a2c56d9
Compare
tylerwowen
force-pushed
the
spr/master/8fdb7dc7
branch
from
cf1a80f
to
edd750e
Compare
tylerwowen
force-pushed
the
spr/master/8fdb7dc7
branch
2 times, most recently
from
2a35306
to
925544c
Compare
ntascii
previously approved these changes
Feb 22, 2024
commit-id:8fdb7dc7 Fix condition for first deploy
tylerwowen
force-pushed
the
spr/master/8fdb7dc7
branch
from
925544c
to
de3d980
Compare
osoriano
reviewed
Jul 25, 2024
| @@ -51,7 +51,7 @@ public class DBHostDAOImpl implements HostDAO { | |||
| private static final String GET_GROUP_SIZE = "SELECT COUNT(host_id) FROM hosts WHERE group_name=?"; | |||
| private static final String GET_ALL_HOSTS_BY_GROUP = "SELECT * FROM hosts WHERE group_name=? AND state!='TERMINATING'"; | |||
| private static final String GET_HOST_BY_NAME = "SELECT * FROM hosts WHERE host_name=?"; | |||
| private static final String GET_HOST_BY_HOSTID = "SELECT * FROM hosts WHERE host_id=?"; | |||
| private static final String GET_HOST_BY_HOSTID = "SELECT * FROM hosts WHERE host_id=? ORDER BY create_date"; | |||
There was a problem hiding this comment.
Any reason to update this?
There was a problem hiding this comment.
Yes. The current order is indeterministic. The new usage bellow will benefit from the ordering. I also checked code references and no existing code depends on the order of this query.
osoriano
reviewed
Jul 25, 2024
deploy-service/common/src/main/java/com/pinterest/deployservice/handler/GoalAnalyst.java
Outdated
Show resolved
Hide resolved
osoriano
previously approved these changes
Jul 30, 2024
osoriano
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add metrics for first deploy success, provision latency and deploy latency
Stack: