Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trim knox key #1433

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Trim knox key #1433

merged 2 commits into from
Feb 2, 2024

Conversation

tylerwowen
Copy link
Contributor

@tylerwowen tylerwowen commented Jan 26, 2024 •
edited
Loading

Replace #1095

Teletraan API and Teletraan Worker read Rodimus API keys from Knox. A newline can be inserted into a Knox key and result in a malformed authentication header. Defensive programming should avoid this mistake.

@tylerwowen tylerwowen requested a review from a team as a code owner January 26, 2024 19:58
@github-actions github-actions bot added the deploy-service Includes changes to deploy-service label Feb 1, 2024
@tylerwowen tylerwowen merged commit 3a59a93 into master Feb 2, 2024
5 checks passed
@tylerwowen tylerwowen deleted the touyang/trim branch February 2, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntascii ntascii ntascii approved these changes

@knguyen100000010 knguyen100000010 knguyen100000010 approved these changes

Assignees

@ntascii ntascii

Labels
deploy-service Includes changes to deploy-service
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tylerwowen @ntascii @knguyen100000010