Validation and related exception handling improvements

[tylerwowen]

Changes

Deploy board

Front end

Slightly improved the UI for displaying auto promotion config change failures.

Back end

The code base doesn't handle IllegalArgumentException everywhere. Changed IllegalArgumentException to a subclass of TeletraanException, so it can be handled whenever TeletraanException is handled. This works because the handling is the same - show users the error.

Teletraan service

Validation

Added constraints to the PromoteBean. When users tried to save an invalid schedule, it will be rejected by validation

Exception handling

Added JerseyViolationExceptionMapper and removed our own handling in GenericExceptionMapper. JerseyViolationExceptionMapper is simply better and it provides a Json as the response body (v.s. plain text).

Additionally, without JerseyViolationExceptionMapper and when an invalid input is caught by validation, the service simply returns 400 without any message, because Jersey's own ConstraintViolationExceptionMapper handles the exception without invoking our GenericExceptionMapper.

Junit 5

Added Junit 5 and used it in the resources tests. Note that Junit 5 can run in parallel with Junit 4.

Validations and tests

Currently, there is no validation. Users can save any schedule and they won't know if it is a valid one.

With this change: