Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional step scaling validations #1460

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Additional step scaling validations #1460

merged 2 commits into from
Feb 22, 2024

Conversation

knguyen100000010
Copy link
Contributor

@knguyen100000010 knguyen100000010 commented Feb 22, 2024 •
edited
Loading

  • Don't allow both steps for up and down be empty. One must be provided.
  • Check if min adjustment is empty.

@knguyen100000010 knguyen100000010 requested a review from a team as a code owner February 22, 2024 13:08
@github-actions github-actions bot added the deploy-board Includes changes to deploy-board label Feb 22, 2024
@knguyen100000010 knguyen100000010 changed the title Minor fix Additional step scaling validations Feb 22, 2024
@knguyen100000010 knguyen100000010 merged commit df42ce8 into master Feb 22, 2024
5 checks passed
@knguyen100000010 knguyen100000010 deleted the minor-fix branch February 22, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwxzhu rwxzhu rwxzhu approved these changes

Assignees
No one assigned
Labels
deploy-board Includes changes to deploy-board
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knguyen100000010 @rwxzhu