Dropwizard migration #1479
Merged
Dropwizard migration #1479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerwowen
force-pushed
the
spr/master/7b820d46
branch
from
0bd393b
to
da05f6b
Compare
tylerwowen
force-pushed
the
spr/master/bff7a566
branch
from
bf44272
to
6141e69
Compare
tylerwowen
force-pushed
the
spr/master/7b820d46
branch
from
da05f6b
to
d764554
Compare
tylerwowen
force-pushed
the
spr/master/bff7a566
branch
from
6141e69
to
286d3dd
Compare
tylerwowen
force-pushed
the
spr/master/bff7a566
branch
2 times, most recently
from
6256308
to
1d32288
Compare
This was referenced Mar 2, 2024
gzpcho
reviewed
Mar 4, 2024
deploy-service/teletraanservice/src/main/java/com/pinterest/teletraan/TeletraanService.java
Show resolved
Hide resolved
vitalii-honchar
previously approved these changes
Mar 4, 2024
There was a problem hiding this comment.
@tylerwowen looks good to me, but please deploy this branch to the test environment and do smoke testing by verifying that the Teletraan project launches and works.
Also attach proof of tests in the PR.
tylerwowen
force-pushed
the
spr/master/bff7a566
branch
from
1d32288
to
e2e7c33
Compare
tylerwowen
force-pushed
the
spr/master/bff7a566
branch
from
e2e7c33
to
5cbc8c2
Compare
commit-id:bff7a566
tylerwowen
force-pushed
the
spr/master/bff7a566
branch
from
5cbc8c2
to
540598a
Compare
vitalii-honchar
approved these changes
Mar 6, 2024
|
@vitalii-honchar thanks for the review. Tests and validations records are internally documented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the major dependency dropwizard to 2.1. Validations and tests are documented internally.
Stack:
Co-authored by: @andreldsr