Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add http download failure metric #1496

Merged
merged 3 commits into from
Mar 15, 2024

Conversation

rwxzhu
Copy link
Contributor

@rwxzhu rwxzhu commented Mar 6, 2024

Add a http download failure metric emission to the deploy-agent.

Tested on devapp by running

> IS_PINTEREST=true METRIC_PORT_HEALTH=18126 METRIC_CACHE_PATH=/mnt/deployd/metrics.cache /home/ruizhu/code/teletraan/deploy-agent/bazel-bin/deployd/deploy-downloader -f /etc/deployagent.conf -v nonexistant_aa874a6 -u https://deployrepo.pinadmin.com/deploy-agent-pex/non_existant-aa874a6.tar.gz -e deploy-init
2024-03-07 03:53:30,000:INFO: Start to download the package.
2024-03-07 03:53:30,000:INFO: Start to download from url https://deployrepo.pinadmin.com/deploy-agent-pex/non_existant-aa874a6.tar.gz to /mnt/builds/deploy-init-nonexistant_aa874a6.tar.gz
2024-03-07 03:53:30,000:INFO: Running command: curl -o /mnt/builds/deploy-init-nonexistant_aa874a6.tar.gz -fksS https://deployrepo.pinadmin.com/deploy-agent-pex/non_existant-aa874a6.tar.gz
2024-03-07 03:53:30,070:INFO: [0.07]curl: (22) The requested URL returned error: 404 Not Found
2024-03-07 03:53:30,070:INFO: Finish downloading: https://deployrepo.pinadmin.com/deploy-agent-pex/non_existant-aa874a6.tar.gz to /mnt/builds/deploy-init-nonexistant_aa874a6.tar.gz
2024-03-07 03:53:30,070:ERROR: Failed to download the tar ball for /mnt/builds/deploy-init-nonexistant_aa874a6.tar.gz
2024-03-07 03:53:30,070:ERROR: Download failed.

metric being populated

Screenshot 2024-03-06 at 10 47 56 PM

@github-actions github-actions bot added the deploy-agent Includes changes to deploy-agent label Mar 6, 2024
@rwxzhu rwxzhu force-pushed the rzhu/agent-download-metric branch from 2d202aa to 49caf33 Compare March 6, 2024 23:42
@rwxzhu rwxzhu marked this pull request as ready for review March 7, 2024 15:01
@rwxzhu rwxzhu requested a review from a team as a code owner March 7, 2024 15:01
vitalii-honchar
vitalii-honchar previously approved these changes Mar 7, 2024
ntascii
ntascii previously approved these changes Mar 8, 2024
@rwxzhu rwxzhu dismissed stale reviews from ntascii and vitalii-honchar via 2c9bdf7 March 8, 2024 20:17
@rwxzhu rwxzhu requested a review from ntascii March 8, 2024 22:24
@rwxzhu rwxzhu merged commit 08b3576 into pinterest:master Mar 15, 2024
7 checks passed
@rwxzhu rwxzhu deleted the rzhu/agent-download-metric branch March 18, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy-agent Includes changes to deploy-agent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants