U24 support for deploy-agent #1634
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osoriano
force-pushed
the
osoriano/deployd-u24
branch
from
c96befb
to
c50f9a5
Compare
yongwen
reviewed
May 30, 2024
| @@ -23,7 +23,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| python-version: [3.7, 3.8] | |||
There was a problem hiding this comment.
@gzpcho do we still have 3.7 use case?
There was a problem hiding this comment.
Updated to 3.6 for consistency. Also specified the Ubuntu version since latest didn't support 3.6
yongwen
reviewed
May 30, 2024
| @@ -14,4 +14,4 @@ commands=py.test --cov=deployd {posargs} | |||
| python = | |||
| 3.6: py36 | |||
There was a problem hiding this comment.
earlier, we have py37, py38? should they be consistent here
There was a problem hiding this comment.
Updated the versions in the GitHub workflow for consistency
Add support for Ubuntu 24 to deploy-agent. This includes adding
support for Python 3.12.
This requires updating some packages (e.g. requests, gevent, boto). For
boto, an `s3_client` class was added to support new (boto3) and old
(boto) packages.
Testing done:
- Unit tests passed
- Installed the deploy-agent package on an Ubuntu 24 host
- Deploy agent ran, but failed due to missing `facter` command
- Installed the deploy-agent package on an Ubuntu 20 host
- The deploy agent worked as expected. Was able to install new
Teletraan builds and restart a Teletraan stage
osoriano
force-pushed
the
osoriano/deployd-u24
branch
3 times, most recently
from
ca03d0c
to
84a37dd
Compare
|
Should also update the bazel requirements: |
|
See #1653 instead I went with a different approach supporting python 3.8 and 3.12 which is more consistent with other components |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Ubuntu 24 to deploy-agent. This includes adding
support for Python 3.12.
This requires updating some packages (e.g.
requests,gevent,boto). Forboto, ans3_clientclass was added to support new (boto3) and old(
boto) packages.Testing done:
factercommandTeletraan builds and restart a Teletraan stage