Redesign host healthcheck display mode #1722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| elif state == "DELETE": | ||
| return "Agent is removed from the current environment" | ||
| elif state == "UNREACHABLE": | ||
| return "Agent is unreachable after not responding to ping from teletraan server" |
There was a problem hiding this comment.
Agent has not pinged Teletraan control plane for X minutes?
There was a problem hiding this comment.
Don't want to explicitly include the timeout duration to become UNREACHABLE as this is set by the backend. How about:
Agent is unreachable after not pinging Teletraan control plane within the threshold
knguyen100000010
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A demo can be found here. In the demo, the states are unsorted, but in a live environment the states will be sorted and the view will be more organized & cohesive. The demo is only to show visual examples of many possible states.
https://jira.pinadmin.com/browse/CDP-8108