Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow none for the third priority backup instance type #1730

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

liyaqin1
Copy link
Contributor

@liyaqin1 liyaqin1 commented Oct 11, 2024

The capacity team has requested a mapping of instance types, which includes only one backup option.

@liyaqin1 liyaqin1 requested a review from a team as a code owner October 11, 2024 19:26
@github-actions github-actions bot added the deploy-board Includes changes to deploy-board label Oct 11, 2024
@liyaqin1
Copy link
Contributor Author

Testing on the integ instance was successful, and everything looks good.

@rfleur01
Copy link
Contributor

Can you include screenshots of the tests?

@liyaqin1
Copy link
Contributor Author

Can you include screenshots of the tests?

I conducted extensive testing and have included some screenshots for your review.
Screenshot 2024-10-11 at 2 13 59 PM
Screenshot 2024-10-11 at 2 13 50 PM
Screenshot 2024-10-11 at 2 15 06 PM

@liyaqin1 liyaqin1 merged commit 091a56f into master Oct 15, 2024
6 checks passed
@liyaqin1 liyaqin1 deleted the yaqin-addNone branch October 15, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy-board Includes changes to deploy-board
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants