-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Slice Sampling: Covariance Matching MCMC #896
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #896 +/- ##
======================================
Coverage 100% 100%
======================================
Files 66 67 +1
Lines 7052 7180 +128
======================================
+ Hits 7052 7180 +128
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very readable code -- nice work! I've suggested a few (very minor) changes. I can't see where this code deviates from what is written. The only thing I'm unsure about is whether ask / tell returns the gradient or negative gradient and if F and R need to be transposed (as this is the last part of your chud function).
Can you add an example notebook here that shows the issue? I couldn't find one.
Sorry it's a different method isn't it? |
Is this ready for re-review @ben18785 ? |
See #772
Includes: