Convert underlying wave buffer to be uint8 #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lherman-cs
force-pushed
the
copy-audio
branch
from
fd902bf to
444a466
Compare
This follows image package from the standard library. By having a homogenous data type for storing the samples, it makes easier to manipulate the raw data in a generic way.
lherman-cs
force-pushed
the
copy-audio
branch
from
444a466 to
25a1bf5
Compare
|
@lherman-cs do you still want to get this in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows image package from the standard library. By having a homogenous data type for storing the samples, it makes easier to manipulate the raw data in a generic way.
The main motivation of doing this is so that we can have ChunkBuffer similar to what we have for images, #209. If we had different data types to store the samples, we need to have multiple slices with different data types or we need to use unsafe to remove the type safety (which is not recommended generally).
This approach is inspired by https://golang.org/src/image/image.go?s=12897:12943#L428.