Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear found drivers in manager on each initialize call (Darwin) #605

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hexbabe
Copy link
Contributor

@hexbabe hexbabe commented Feb 11, 2025

Description

In camera_linux.go, we clear all registered camera devices to prevent duplicates each time Initialize is called. We should do the same for Darwin

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 45.87%. Comparing base (c10fb00) to head (a4a536c).

Files with missing lines Patch % Lines
pkg/driver/camera/camera_darwin.go 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #605      +/-   ##
==========================================
+ Coverage   44.67%   45.87%   +1.20%     
==========================================
  Files          80       77       -3     
  Lines        5498     4955     -543     
==========================================
- Hits         2456     2273     -183     
+ Misses       2875     2522     -353     
+ Partials      167      160       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant