Fix the VPX encoder is not properly handling the frame timestamp #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #606 +/- ##
==========================================
- Coverage 44.67% 44.61% -0.06%
==========================================
Files 80 80
Lines 5498 5498
==========================================
- Hits 2456 2453 -3
- Misses 2875 2877 +2
- Partials 167 168 +1 ☔ View full report in Codecov by Sentry. |
at-wat
reviewed
Feb 13, 2025
Co-authored-by: Atsushi Watanabe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue with VPX encoder that using
time.Now().Nanosecond() / 1000000as the timestamp marker and make the timestamp is not monotonic and there is a potential issue the frame duration become negative and make the encoding failed.Check the new test included in this PR to reproduce the issue.
Updated:
I just saw this issue seems similar to #603 I can close this one and merge that one if needed.