Use crypto/rand instead of math/rand #359
Conversation
|
Nice catch! Thank you @dkess MInd using randutil.GenerateCryptoRandomString After pion/turn was created we started moving our duplicated random/crypto logic to this repo. Sorry to make you do the extra work :/ |
|
No problem. Updated the PR. Thanks for the pointer. |
Codecov ReportAttention:
... and 1 file with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
Use crypto/rand and pion/randutil instead of math/rand math/rand isn't suitable for security-sensitive contexts, so replace it with cryptographically secure random string generation.
|
merged! @dkess any interest in staying involved? I would love to add you to the Pion org. If you have other things that could be improved with this repo, would love to support you :) |
|
Happy to be part of the org :) I don't know of any improvements yet, but I do plan to use the ICE library for an upcoming project at my workplace. I'll definitely be keeping an eye on the project and plan to participate as needed. |
math/rand isn't suitable for security-sensitive contexts. This PR replaces it with crypto/rand (which uses the somewhat inconvenient big.Int type).