Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support stand alone STUN server mode #383

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Conversation

Sean-Der
Copy link
Member

@Sean-Der Sean-Der commented Apr 4, 2024

Running in stand alone STUN server does not start
due to packet conn config requiring relay address config during validation.

To enable that mode, bypass validation if relay address config in packet conn config is nil.

Note that it is still validated in ListenerConfig.

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 57.89474% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 66.65%. Comparing base (33c87de) to head (b4a15e7).

Files Patch % Lines
server.go 37.50% 5 Missing ⚠️
server_config.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #383      +/-   ##
==========================================
- Coverage   66.68%   66.65%   -0.04%     
==========================================
  Files          43       43              
  Lines        2888     2903      +15     
==========================================
+ Hits         1926     1935       +9     
- Misses        796      801       +5     
- Partials      166      167       +1     
Flag Coverage Δ
go 66.65% <57.89%> (-0.04%) ⬇️
wasm 26.90% <0.00%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Running in stand alone STUN server does not start
due to packet conn config requiring relay address config
during validation.

To enable that mode, bypass validation if relay address config
in packet conn config is nil.

Note that it is still validated in `ListenerConfig`.
Copy link
Contributor

@boks1971 boks1971 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!!! Thank you @Sean-Der

@Sean-Der Sean-Der merged commit ed59abf into master Apr 4, 2024
14 of 15 checks passed
@Sean-Der Sean-Der deleted the raja_standalone_stun branch April 4, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants