Skip to content

Commit

Permalink
Close answer and assert errors in detach tests
Browse files Browse the repository at this point in the history
  • Loading branch information
pabloFuente committed Jan 16, 2025
1 parent 032ce48 commit 882e1d0
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions datachannel_go_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -826,22 +826,26 @@ func TestDataChannelClose(t *testing.T) {
func TestDataChannel_DetachErrors(t *testing.T) {
t.Run("error errDetachNotEnabled", func(t *testing.T) {
s := SettingEngine{}
offer, _, _ := NewAPI(WithSettingEngine(s)).newPair(Configuration{})
offer, answer, err := NewAPI(WithSettingEngine(s)).newPair(Configuration{})
assert.NoError(t, err)
dc, err := offer.CreateDataChannel("data", nil)
assert.NoError(t, err)
_, err = dc.Detach()
assert.ErrorIs(t, err, errDetachNotEnabled)
assert.NoError(t, offer.Close())
assert.NoError(t, answer.Close())
})

t.Run("error errDetachBeforeOpened", func(t *testing.T) {
s := SettingEngine{}
s.DetachDataChannels()
offer, _, _ := NewAPI(WithSettingEngine(s)).newPair(Configuration{})
offer, answer, err := NewAPI(WithSettingEngine(s)).newPair(Configuration{})
assert.NoError(t, err)
dc, err := offer.CreateDataChannel("data", nil)
assert.NoError(t, err)
_, err = dc.Detach()
assert.ErrorIs(t, err, errDetachBeforeOpened)
assert.NoError(t, offer.Close())
assert.NoError(t, answer.Close())
})
}

0 comments on commit 882e1d0

Please sign in to comment.