NewAPI: register default codecs and interceptors #2630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2630 +/- ##
==========================================
- Coverage 76.46% 76.34% -0.13%
==========================================
Files 87 87
Lines 9867 9879 +12
==========================================
- Hits 7545 7542 -3
- Misses 1855 1865 +10
- Partials 467 472 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Hey @Sean-Der, I've fixed the failing tests. Can you approve the CI run please? Should I update the examples and other tests to remove the setup code for default codecs / interceptors? |
|
Full context/justification for this change
|
Sean-Der
approved these changes
Dec 11, 2023
andrein
added a commit
to andrein/webrtc
that referenced
this pull request
Dec 11, 2023
The NewAPI() function already registers them by default (since pion#2630)
andrein
added a commit
to andrein/webrtc
that referenced
this pull request
Dec 11, 2023
Skip registering the default codecs and interceptors in NewPeerConnection. The NewAPI() function already registers them by default (since pion#2630)
Sean-Der
pushed a commit
that referenced
this pull request
Mar 18, 2024
Skip registering the default codecs and interceptors in NewPeerConnection. The NewAPI() function already registers them by default (since #2630)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed on Discord with @Sean-Der,
NewAPI()should register default codecs and interceptors unless configured otherwise.