Add ivfwriter support for VP9 #2938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2938 +/- ##
==========================================
- Coverage 78.33% 78.14% -0.20%
==========================================
Files 91 91
Lines 11128 11159 +31
==========================================
+ Hits 8717 8720 +3
- Misses 1925 1947 +22
- Partials 486 492 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kevmo314
force-pushed
the
vp9-ivfwriter
branch
2 times, most recently
from
399dfbf to
8569a45
Compare
kevmo314
changed the title
kevmo314
force-pushed
the
vp9-ivfwriter
branch
from
8569a45 to
2364de9
Compare
kevmo314
force-pushed
the
vp9-ivfwriter
branch
4 times, most recently
from
a54f1bc to
a0a3d53
Compare
Sean-Der
force-pushed
the
vp9-ivfwriter
branch
2 times, most recently
from
ad39010 to
00c8e22
Compare
Adds the necessary wiring to get VP9 to work with `ivfwriter`. Update the README of save-to-disk to inform users it supports both VP8 and VP9. ivfwriter currently assumes 30 fps but it seems that the other codecs also assume 30 fps so that is not a net-new assumption.
Sean-Der
force-pushed
the
vp9-ivfwriter
branch
from
00c8e22 to
427ea45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the necessary wiring to get VP9 to work with
ivfwriteraswell as a save-to-disk example.
It currently assumes 30 fps but it seems that the other codecs
also assume 30 fps so that is not a net-new assumption.
Reference issue
Fixes #...