Include sdpMid and sdpMLineIndex for ICECandidates returned by OneICECandidate #2990
+375
−58
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, Pion returns an empty
sdpMid
and a 0sdpMLineIndex
. This PR ensures Pion returns the correspondingsdpMid
andsdpMLineIndex
for ICE candidates for clients that expects it. Fixes trickle issues.Changes
ICECandidates
: New fieldsSDPMid
andSDPMLineIndex
.ICECandidates
: Two new constructorsnewIdentifiedICECandidateFromICE
andnewIdentifiedICECandidatesFromICE
.ICEGatherer
:SetMediaStreamIdentification
and return the correctSDPMid
andSDPMLineIndex
.extractICEDetails
: Return a struct instead of multiple valuessdpICEDetails
, return the pickedSDPMid
andSDPMLineIndex
.Reference issue
Fixes #2690
Fixes #1833