Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated safety comment in RegisterCodec #3017

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

JoeTurki
Copy link
Member

Description

The removed comment predates the introduction of locks in the RegisterCodec method.

The removed comment predates the introduction of locks in the
RegisterCodec method.
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.54%. Comparing base (feeeebf) to head (47c65c8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3017      +/-   ##
==========================================
+ Coverage   78.47%   78.54%   +0.07%     
==========================================
  Files          89       89              
  Lines       11037    11037              
==========================================
+ Hits         8661     8669       +8     
+ Misses       1890     1883       -7     
+ Partials      486      485       -1     
Flag Coverage Δ
go 80.09% <ø> (+0.07%) ⬆️
wasm 63.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoeTurki JoeTurki merged commit 47c65c8 into master Jan 22, 2025
18 checks passed
@JoeTurki JoeTurki deleted the chore/remove-old-comment branch January 22, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants