Preserve ICE candidate Extensions #3024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeTurki
force-pushed
the
impr/ice-candidate-extensions
branch
from
1f7e2dd to
bacd6b7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3024 +/- ##
==========================================
+ Coverage 78.40% 78.57% +0.17%
==========================================
Files 89 89
Lines 11037 11078 +41
==========================================
+ Hits 8654 8705 +51
+ Misses 1894 1885 -9
+ Partials 489 488 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
JoeTurki
force-pushed
the
impr/ice-candidate-extensions
branch
3 times, most recently
from
dea14d6 to
eb6f46b
Compare
Ensure that ICE candidates are retained when parsed and stringified, and converted to ICE.candidate.
JoeTurki
force-pushed
the
impr/ice-candidate-extensions
branch
from
eb6f46b to
a0d7d02
Compare
|
@Sean-Der I've updated the implementation so that the ICECandidate stores extensions as a string with minimal serialization instead of a slice. to ensure that it remain compatible (equality), All private implementations, hope that was ok. |
|
@JoeTurki Sounds great to me! I have no idea what is really going on, but I trust your judgement :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensure that ICE candidates are retained when parsed and stringified, and converted back to ICE.candidate.
Reference issue
required ICE PR pion/ice#758 and pion/ice#759
Partly solves #2993